Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
humanagent
changed the title
humanagent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Ethereum address resolution utilities to
sdks/agent-sdk/src/user/NameResolver.tsfor parsing mentions and resolving Farcaster domainsIntroduce
user.NameResolverhelpers to parse message mentions and resolve identifiers, includingmatchShortenedAddress,extractMemberAddresses,resolveIdentifier,extractMentions,resolveMentionsInMessage, andfetchFarcasterProfilein NameResolver.ts.📍Where to Start
Start with
resolveIdentifierand its call sites in NameResolver.ts.📊 Macroscope summarized 9aae076. 1 file reviewed, 3 issues evaluated, 1 issue filtered, 1 comment posted
🗂️ Filtered Issues
sdks/agent-sdk/src/user/NameResolver.ts — 1 comment posted, 3 evaluated, 1 filtered
fetchFarcasterProfilesets theX-API-KEYheader value toBearer ${apiKey}instead of the raw API key. Most APIs that useX-API-KEYexpect the key directly, whileBeareris typically used with theAuthorizationheader. This likely causes authenticated requests to fail silently, and the function will always returnemptyProfile. Update the header toheaders["X-API-KEY"] = apiKey(or useAuthorization: Bearer ...if that is the documented contract). [ Low confidence ]